- 
                Notifications
    You must be signed in to change notification settings 
- Fork 36
Update xeus-cpp to 0.7.1 for release #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xeus-cpp to 0.7.1 for release #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| #define XEUS_CPP_VERSION_MINOR 8 | ||
| #define XEUS_CPP_VERSION_PATCH 0 | ||
| #define XEUS_CPP_VERSION_LABEL dev | ||
| #define XEUS_CPP_VERSION_MINOR 7 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'XEUS_CPP_VERSION_MINOR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define XEUS_CPP_VERSION_MINOR 7
        ^| #define XEUS_CPP_VERSION_PATCH 0 | ||
| #define XEUS_CPP_VERSION_LABEL dev | ||
| #define XEUS_CPP_VERSION_MINOR 7 | ||
| #define XEUS_CPP_VERSION_PATCH 1 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'XEUS_CPP_VERSION_PATCH' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define XEUS_CPP_VERSION_PATCH 1
        ^| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           🚀 New features to boost your workflow:
 | 
a40b0c5    to
    c92d3e0      
    Compare
  
    | Closing as #346 is merged. | 
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.